This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
XCM Revamp Continued #2865
Merged
XCM Revamp Continued #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-in_progress
47 tasks
gavofyork
added
A0-please_review
shawntabrizi
reviewed
Apr 9, 2021
shawntabrizi
reviewed
Apr 9, 2021
Comment on lines
+340
to
+341
| // we increase the amount of weight that we're allowed to use on the first message to try to prevent | ||
| // the possibility of blockage of the queue. |
There was a problem hiding this comment.
this scenario is not quite clear to me yet
There was a problem hiding this comment.
The original UMP dispatcher guaraunteed one dispatch per block minimum with the weight limitation being a soft cap. This kept things running the case of a single heavy message. Now, we don't quite guarantee that, but the soft-cap gets lifted to this hard-cap for the first message per block to try to mitigate any blockage.
shawntabrizi
reviewed
Apr 9, 2021
shawntabrizi
reviewed
Apr 9, 2021
kianenigma
reviewed
Apr 9, 2021
kianenigma
reviewed
Apr 9, 2021
kianenigma
reviewed
Apr 9, 2021
| fn execute_xcm(_origin: MultiLocation, _message: Xcm<C>, _weight_limit: Weight) -> Outcome { | ||
| Outcome::Error(Error::Unimplemented) | ||
| } | ||
| } | ||
|
|
||
| /// Utility for sending an XCM message. | ||
| /// | ||
| /// These can be amalgamted in tuples to form sophisticated routing systems. | ||
| pub trait SendXcm { |
There was a problem hiding this comment.
I was reading this few hours ago and this was a fundamental part of the code without docs, thanks for filling 👍
shawntabrizi
approved these changes
Apr 9, 2021
kianenigma
approved these changes
Apr 9, 2021
rphmeier
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Introduce plurality XCM locations * Add RelayedFrom * DMP dispatch weight handling. * Add pallet for XCM sending, add routing logic. * Update error types & doc * Fix warnings. * Fixes * Fixes * Fixes * Bump Substrate * Fixes * Docs * Docs * Docs * Fixes * Fixes * Fixes * Update xcm/pallet-xcm/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Docs * Fixes * Update lib.rs * Fixes Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #2841
This batch of work is mostly to allow governance VMP messages.
pallet-xcm, this is a pallet which contains dispatchables to send and execute XCM messages. Also contains a MultiLocationOriginand a correspondingEnsureOriginimplementation to recognise it as well as a body-majority.process_upward_messagein order to take the acceptable amount of weight to spend processing the message, and return an Option to indicate whether the weight limit was reached.XcmPalletto Rococo runtime.TODO in another PR: